Documentation: fix the update_readme script#3186
Draft
ManonMarchand wants to merge 2 commits into
Draft
Conversation
it is platform in the cli and platforms in the pyproject so this was a bit confusing
Member
|
Thanks for the PR, tests are failing. |
Contributor
Author
|
Yes, I'll have time to fix the tests on monday. I'm switching to draft for now 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello maturin maintainers 👋
This PR does two things:
fixes the script
update readme.pyThe regexp was failing in two cases:
bash\nUsage:instead ofUsage:generate-ci)Now that it works I ran it and the documentation is up to date again.
adds a precision in
generate-cidocThe deprecated argument is
platformand the argument in the pyproject isplatforms(plural). Took me some time to figure it out so I thought I'd add a precision in the documentation.